-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx argparse #1581
Sphinx argparse #1581
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1581 +/- ##
==========================================
+ Coverage 70.51% 70.59% +0.08%
==========================================
Files 379 379
Lines 59118 59143 +25
Branches 21237 21253 +16
==========================================
+ Hits 41686 41752 +66
+ Misses 14359 14319 -40
+ Partials 3073 3072 -1
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ischoegl. I think this makes sense, and clearly fits in with Cantera/enhancements#178 without getting too far ahead of ourselves. I had just a couple of minor questions / suggestions.
8393f0b
to
382e7ca
Compare
382e7ca
to
efe360c
Compare
@speth ... this should likewise be ready. I added module-level PS: Once we get to 3.0, it may make sense to use |
Yes, I agree that modifying |
New doc dependency introduced by Cantera/cantera#1581
New doc dependency introduced by Cantera/cantera#1581
New doc dependency introduced by Cantera/cantera#1581
Changes proposed in this pull request
Improve documentation of converter scripts.
If applicable, fill in the issue number this pull request is fixing
Closes #1577
May create pages that could receive website content (see Cantera/enhancements#178)
Checklist
scons build
&scons test
) and unit tests address code coverage